[PATCH 2/8] Bug 9395 - Samba fails the simple_nodelete test of smb2.rename tests from master.
Jeremy Allison
jra at samba.org
Fri Nov 16 12:54:14 MST 2012
Rename opens should always only ask for DELETE_ACCESS. This makes the
access_mask parameter redundent, next patch will change it to be a
share_access parameter instead (which does vary between NTCreateX and
SMBmv calls).
Signed-off-by: Jeremy Allison <jra at samba.org>
---
source3/smbd/reply.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/source3/smbd/reply.c b/source3/smbd/reply.c
index f1c7478..d53b342 100644
--- a/source3/smbd/reply.c
+++ b/source3/smbd/reply.c
@@ -6591,7 +6591,7 @@ NTSTATUS rename_internals(TALLOC_CTX *ctx,
req, /* req */
0, /* root_dir_fid */
smb_fname_src, /* fname */
- access_mask, /* access_mask */
+ DELETE_ACCESS, /* access_mask */
(FILE_SHARE_READ | /* share_access */
FILE_SHARE_WRITE),
FILE_OPEN, /* create_disposition*/
@@ -6737,7 +6737,7 @@ NTSTATUS rename_internals(TALLOC_CTX *ctx,
req, /* req */
0, /* root_dir_fid */
smb_fname_src, /* fname */
- access_mask, /* access_mask */
+ DELETE_ACCESS, /* access_mask */
(FILE_SHARE_READ | /* share_access */
FILE_SHARE_WRITE),
FILE_OPEN, /* create_disposition*/
--
1.7.7.3
More information about the samba-technical
mailing list