smb2_file_rename_information must check that the file has been opened with DELETE Access ...

Christian Ambach ambi at
Fri Nov 16 00:30:46 MST 2012

Hi Jeremy,

On 11/15/2012 10:50 PM, Jeremy Allison wrote:
> Thanks - it's much appreciated. The real issue is that the
> tests open the containing directory with access masks of
> FILE_READ_DATA|FILE_WRITE_DATA, which cause share modes
> to be checked - something I don't think *any* windows
> clients ever do against a directory handle (the MS Word
> test you wrote certainly doesn't) as any requests for
> reads and writes on the raw directory handle will be
> rejected anyway.

Feel free to make the testcases more reality-like :)
It was merely a copy&paste from existing ones, the only test were I
really looked at the various access masks is the msword one because I
took the values from a real network sniff for it.


More information about the samba-technical mailing list