smb2_file_rename_information must check that the file has been opened with DELETE Access ...

Christian Ambach ambi at
Thu Nov 15 14:40:02 MST 2012

Hi Jeremy,

On 11/14/2012 11:54 PM, Jeremy Allison wrote:

>> Do we have an existing piece in the smb2 torture tests that shows that
>> this necessary? If there is a test in place, I think the patch is valid.
> Yep, we already have such a test. Check out smb2.rename - and we have:
> selftest/knownfail:^samba3.smb2.rename.*.simple_nodelete
> selftest/knownfail:^samba3.smb2.rename.*.no_share_delete_no_delete_access

> So I think we can scratch some of these knownfails off the list with this
> fix :-).

So you decided to put it in the sharemode check that you considered to
be unnecessary in Bug 8412? Good to hear that :)

I was the one who wrote most of these tests to show that the fix was not
complete (but also make sure we don't fail with MS Word again).


More information about the samba-technical mailing list