[PATCH v2] samba-tool dns: Give a better error message when people get the server parameter wrong

[Rowland Penny]

On 14/11/12 11:03, Kai Blin wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 2012-11-14 11:45, Jelmer Vernooij wrote:
>> On Wed, 2012-11-14 at 11:37 +0100, Kai Blin wrote:
>>> Can someone ack and push or propose a better patch?
>> The change itself is a bit of a hack, though I guess not too
>> harmful. ACK. (I don't do reviewer-push).
> I'm trying to play along and not push my own patches, so here's the
> updated version with a Reviewed-by tag added for jelmer's ACK.
>
> Anybody with commit access, feel free to push it.
> Kai
>
> - --
> Kai Blin
> Worldforge developer http://www.worldforge.org/
> Wine developer http://wiki.winehq.org/KaiBlin
> Samba team member http://www.samba.org/samba/team/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://www.enigmail.net/
>
> iEYEARECAAYFAlCjenYACgkQEKXX/bF2FpTzIACeIQBlliBmGeqLLb+LqDLzdNZp
> 7yoAn2GQT74/Ng1ijk8iTC6CgDMR6IAw
> =Q0+9
> -----END PGP SIGNATURE-----
>
Hi, Now I will be the first to acknowledge that I know nothing about 
writing software, but instead of writing a better error message, 
wouldn't it be better to fix the problem?
On my samba4 server (ipaddress 192.168.0.10, FQDN adserver.home.lan) all 
the following commands work & give the same information

samba-tool dns serverinfo 127.0.0.1
samba-tool dns serverinfo 192.168.0.10
samba-tool dns serverinfo adserver
samba-tool dns serverinfo adserver.home.lan

The only command that fails is:
samba-tool dns serverinfo localhost

Wouldn't it be better to get localhost to work and print an error 
message along the lines of 'information not available for <what ever was 
given>, please check and retry' if the wrong server was given.

Rowland

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.