smb2_file_rename_information must check that the file has been opened with DELETE Access ...

Richard Sharpe realrichardsharpe at
Tue Nov 13 21:38:03 MST 2012

Hi folks,

One of the smb2 tests shows that you can only do a SET_FILE_INFO
Rename Info if you have the source file open for delete.

This is confirmed by MS-FSCC section x.y.z. I will confirm the
specific section tomorrow.

The following is a potential fix.

diff --git a/source3/smbd/trans2.c b/source3/smbd/trans2.c
index 61d755c..d919ad4 100644
--- a/source3/smbd/trans2.c
+++ b/source3/smbd/trans2.c
@@ -6100,6 +6100,9 @@ static NTSTATUS smb2_file_rename_information(connection_st
                return NT_STATUS_INVALID_PARAMETER;

+       if (!(fsp->access_mask & DELETE_ACCESS)) {
+               return NT_STATUS_ACCESS_DENIED;
+       }
        srvstr_get_path(ctx, pdata, req->flags2, &newname,
                                &pdata[20], len, STR_TERMINATE,

Richard Sharpe

More information about the samba-technical mailing list