[PATCH] SYSVOL ACL fixes Re: [PATCH] Fix 'samba-tool ntacl sysvolcheck' failures and remove NT4 compat

Andrew Bartlett abartlet at samba.org
Tue Nov 13 16:14:28 MST 2012

On Tue, 2012-11-13 at 13:45 -0800, Jeremy Allison wrote:
> On Wed, Nov 14, 2012 at 08:32:44AM +1100, Andrew Bartlett wrote:
> > 
> > It's a fair cop, and I agree.
> :-).
> > I'm not as convinced that the other patches break up so well, but I
> > guess you could remove the smb.conf parameter, and then the manpages for
> > "acl compatability" in distinct patches if that was your preference.
> No, the others are more logically grouped, so I didn't split them. I
> thought the "acl compatability" one could have been split up the way
> you describe, but it's not such a big deal when it's not code changes,
> but only man page changes.
> > I'm certainly not wanting to be a pain here, so please let me know what
> > would help you best here.  Are you still splitting them up, or would you
> > prefer me to just re-submit?
> Already did it :-).
> FYI. I'm missing the last patch in your set (the samba-tool
> one) as that one didn't apply to master but gave conflicts.

That's very odd.  I've just applied the attached on top of my changes
and master, without any errors.  Are you sure this is on master, not

> Can you re-evaluate this set and if you're happy then push to
> autobuild.

I'm autobuilding the returned patched now.  


Andrew Bartlett

Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-samba-tool-Add-new-samba-tool-gpo-aclcheck-and-test.patch
Type: text/x-patch
Size: 4600 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20121114/0a72ba82/attachment.bin>

More information about the samba-technical mailing list