FLAKEY: selftest: check that samba-tool gpo works for basic operations

Andrew Bartlett abartlet at samba.org
Mon Nov 12 21:37:59 MST 2012


On Tue, 2012-11-13 at 14:45 +1100, Andrew Bartlett wrote:
> On Tue, 2012-11-06 at 15:28 +0100, Jelmer Vernooij wrote:
> > On Tue, 2012-11-06 at 14:36 +0100, Stefan (metze) Metzmacher wrote:
> > > Hi Jelmer,
> > > 
> > > > On Tue, 2012-11-06 at 12:15 +0100, Stefan (metze) Metzmacher wrote:
> > > >>> If we can figure out why the create fails (and so does not print the guid) we may be a long way to solving the fundamental issues with GPO support.  I'm dealing with a family thing this week so I would really appreciate it if you could have a look at it for me.
> > > >>
> > > >> Ok, I'll see what I can do.
> > > >>
> > > >> But for now I'll add this to the skip list.
> > > > Please add this specific test to the flakey test list rather than adding
> > > > it to the skip list.
> > > 
> > > It generates an error not a failure...
> > We should be checking for it explicitly, and turn this error into a
> > failure I think. If we skip the testsuite then we're ignoring not
> > running the testsuite at all rather than ignoring the flakiness of one
> > individual test.
> 
> So, just to loop back.  Looking again at the flaky mail I just got, the
> issue was that when I called 'samba-tool gpo create' I forgot to
> indicate --tmpdir, and so if another user was running or had run an
> autobuild, it would fail (unable to use the directory).
> 
> I've fixed this, so it shouldn't come back.  

I spoke too soon, but this patch should do it.  Please review.

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-selftest-Add-tmpdir-to-samba-tool-gpo-create-test.patch
Type: text/x-patch
Size: 3240 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20121113/500e01d0/attachment.bin>


More information about the samba-technical mailing list