A small error message fix in source3/smbd/server.c

[Volker Lendecke]

On Mon, Nov 12, 2012 at 05:39:34PM +1100, Andrew Bartlett wrote:
> On Mon, 2012-11-12 at 07:34 +0100, Volker Lendecke wrote:
> > On Sun, Nov 11, 2012 at 09:18:56AM -0800, Richard Sharpe wrote:
> > > Hi folks,
> > > 
> > > The following patch removes some incorrect info from an error message
> > > (probably from its old place when it was copied:
> > > 
> > > diff --git a/source3/smbd/server.c b/source3/smbd/server.c
> > > index 7113eae..f33046b 100644
> > > --- a/source3/smbd/server.c
> > > +++ b/source3/smbd/server.c
> > > @@ -551,7 +551,7 @@ static void smbd_accept_connection(struct tevent_context *ev
> > >                 return;
> > > 
> > >         if (fd == -1) {
> > > -               DEBUG(0,("open_sockets_smbd: accept: %s\n",
> > > +               DEBUG(0,("accept: %s\n",
> > >                          strerror(errno)));
> > >                 return;
> > >         }
> > 
> > If you're going there, I'd change the string to 
> > 
> > "smbd_accept_connection: accept failed: %s\n"
> > 
> > because the convention at least I see a lot is to have the
> > function name that is calling this before the :.
> 
> Well, we did agree to stop putting function names there, but the patch
> to change our debug code to always use the 'header' format that includes
> the function name and line number seemed to stall out a few months
> ago.  

Well, I think we have to respect people's wishes to use
function names here as we have to respect people's wishes to
not obey with other parts of README.Coding like the 80-char
length limitation and trailing whitespace.

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de