[PATCH] Even more selftest improvements for ACLs
jelmer at samba.org
Sun Nov 11 15:26:09 MST 2012
On Mon, Nov 12, 2012 at 08:06:15AM +1100, Andrew Bartlett wrote:
> On Sun, 2012-11-11 at 13:44 +0100, Jelmer Vernooij wrote:
> > On Sun, 2012-11-11 at 23:42 +1100, Andrew Bartlett wrote:
> > > The attached patches help improve our selftest system around ACLs. In
> > > particular, the case that caused use of talloc memory after free is now
> > > covered.
> > ACK to all three.
> > Cheers,
> Thinking over one concern I had overnight about these patches, I've
> finally come up with a better way to isolate these tests - make the
> whole xattr.tdb per-unit test.
> Let me know what you think.
ACK, That seems reasonable to me. Minor nitpick: please use spaces
after commas, like we do in the C code.
More information about the samba-technical