[PATCH] Add notes for DRS

Matthieu Patou mat at samba.org
Sat Nov 10 22:25:17 MST 2012

On 11/10/2012 06:04 PM, Andrew Bartlett wrote:
> On Fri, 2012-11-09 at 00:13 -0800, Matthieu Patou wrote:
>> Hello,
>> I'd like to push a patch like the one attached to this email.
>> It's just comments but I started to document what we don't do right in
>> the code for DRS with some FIXME, some can argue that this has no value
>> but I don't think so as it spots what is wrong in our current behavior
>> and helps to better understand why samba didn't send the same message
>> sequence as windows.
>> Feel free to push if ok, if not I won't battle for pushing this patch.
> I was about to push it, but I'm not sure I really understand it, so
> perhaps if you could explain a little more what you are trying to
> document here, we can have another go.
I'm adding notes on the behavior that we have in 
source4/dsdb/repl/drepl_out_helpers.c, I'm trying to explain why it's 
wrong to send the updaterefs after each getncchanges and that it should 
be done in the KCC.


Matthieu Patou
Samba Team

More information about the samba-technical mailing list