[PATCH 11/12] torture: add locking tests for copychunk

David Disseldorp ddiss at suse.de
Thu Nov 8 05:32:48 MST 2012


On Thu, 08 Nov 2012 01:44:06 +0100
Jelmer Vernooij <jelmer at samba.org> wrote:

> > +	ok = test_setup_copy_chunk(torture, tree, tmp_ctx,
> > +				   1, /* chunks */
> > +				   &src_h, 4096, /* src file */
> > +				   &dest_h, 0,	/* dest file */
> > +				   &cc_copy,
> > +				   &ioctl);
> > +	if (!ok) {
> > +		return false;
> > +	}  
> You probably want to indicate a failure here, either by calling the
> torture_fail() convenience macro or torture_result(), for which it is a
> wrapper.
> 
> Without this, the testsuite will report the test result as error rather
> than failure and without a specific reason.

The test_setup_copy_chunk() error paths already print information
regarding the failure, I'll change this over anyhow.

Cheers, David


More information about the samba-technical mailing list