[PATCH 08/12] torture: skip FSCTL_SRV_ENUM_SNAPS test when not supported
David Disseldorp
ddiss at suse.de
Thu Nov 8 05:28:23 MST 2012
On Thu, 08 Nov 2012 01:39:01 +0100
Jelmer Vernooij <jelmer at samba.org> wrote:
> > status = smb2_ioctl(tree, tmp_ctx, &ioctl.smb2);
> > + if (NT_STATUS_EQUAL(status, NT_STATUS_NOT_SUPPORTED)
> > + || NT_STATUS_EQUAL(status, NT_STATUS_INVALID_DEVICE_REQUEST)) {
> > + torture_comment(torture,
> > + "FSCTL_SRV_ENUM_SNAPS not supported, skipping\n");
> > + return true;
> > + }
> > torture_assert_ntstatus_ok(torture, status, "FSCTL_SRV_ENUM_SNAPS");
> >
> > return true;
> Rather than torture_comment() and 'return true', it's better to use
> torture_skip() here. That will properly mark the test as skipped in the
> test output.
Thanks Jelmer, I'll change this over.
Cheers, David
More information about the samba-technical
mailing list