[PATCH 1/2] s3fs-popt: Add function to burn the commandline password.

Scott Lovenberg scott.lovenberg at gmail.com
Mon Nov 5 14:29:58 MST 2012

On Mon, Nov 5, 2012 at 3:43 PM, Michael Adam <obnox at samba.org> wrote:
> > It creates 99% more safety than before.
> I still think that there is no real safety in these patches, but
> 99% more niceness for the carless commandline user.
> As such, it is ok and good to have.
> One comment on the patchset, on the burn function to be precise:
> What happens if the user specifies -U / --user more than once on
> the cmdline? Am I reading the code correctly in that it only
> burns the first occurrence?
> Cheers - Michael

Well, if the worry is about careless commandline users, you could
always inform them that they're being dangerous.  For instance, we
output to stderr when someone uses a deprecated mount option (BTW,
username=user%password is deprecated in cifs-utils-5.7) for CIFS.
"Hey, you.  Yes, you!  You're doing something silly and dangerous.
Stop it. You can use a credentials file." might not be the worst thing
in the world (more properly worded of course).

I was reading the thread and thinking about spinning up a patch that
does the same thing for mount.cifs, but I'm really not sure that the
mount process is long lasting enough that it would make any real-world
difference.  If the idea has any support, I'll write a patch to add
this feature to mount.cifs.c in the cifs-utils package.

Peace and Blessings,

More information about the samba-technical mailing list