[PATCH] Improve wintest to try and dcpromo more of the time

Jelmer Vernooij jelmer at samba.org
Mon Nov 5 13:22:22 MST 2012

On Mon, Nov 05, 2012 at 10:05:08PM +1100, Andrew Bartlett wrote:
> This attempts to give the unreliable dcpromo process more of a chance. 
> The underlying cause of the failure still isn't well understood, it just
> seems unreliable when run from telnet. 
This seems reasonable to me.

> diff --git a/wintest/wintest.py b/wintest/wintest.py
> index c0f1eeb..c5dc820 100644
> --- a/wintest/wintest.py
> +++ b/wintest/wintest.py
> +        child = self.open_telnet("${WIN_HOSTNAME}", "administrator", "${WIN_PASS}")
> +        # Give DNS registration a kick
> +        if not self.get_is_dc(child):
> +                raise Exception("dcpromo failed (and wasn't a DC even after rebooting)")
   ^^^ This seems to use 8-space tabs, rather than 4-space as
   in our other Python code.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20121105/3269a517/attachment.pgp>

More information about the samba-technical mailing list