[PATCH 0/3] Fix mixing of excludes/includes in abi_match

[Jelmer Vernooij]

On Tue, 2012-11-06 at 07:11 +1100, Andrew Bartlett wrote:
> On Mon, 2012-11-05 at 19:36 +0100, Jelmer Vernooij wrote:
> > This patchset adds a couple of unit tests for the write_vscript_abi() function,
> > and fixes a recent regression in that function.
> > 
> > ldb uses a abi_match of '!ldb_*module_ops !ldb_*backend_ops ldb_*'.
> > After a recent change (9c3e294400234ebdf9b98031bae583524fd0b0ac) to wafsamba
> > this line causes symbols with the prefixes rep_ and map_ to be public. This
> > patchset fixes wafsamba to no longer expose these symbols, as it did prior
> > to September.
> > 
> > Note that ldb 1.1.12 was released with the broken version of samba_abi,
> > and thus includes some public symbols that shouldn't actually be public.
> > 
> > Jelmer Vernooij (3):
> >   wafsamba.samba_abi: Refactor abi_write_vscript to take file argument.
> >   wafsamba.samba_abi: Add basic unit tests.
> >   wafsamba.abi: Fix abi_match with both excludes and includes.
> > 
> >  buildtools/wafsamba/samba_abi.py      | 30 +++++++++-------
> >  buildtools/wafsamba/tests/test_abi.py | 67 +++++++++++++++++++++++++++++++++++
> >  2 files changed, 84 insertions(+), 13 deletions(-)
> 
> This looks good, and I'm really glad to see it has tests.  Do we need to
> bump the ldb version and re-release, with a forced --abi-update?
Thanks.

I don't think we need to do a forced ABI update for this; the symbols
exposed shouldn't actually be used by any users (they're not in the
header files either), and they've only been present in one minor
release. 

It might be nice to do a new ldb release for this, though (with my
Debian/Ubuntu packager hat on) I'm personally not in a hurry. 

Cheers,

Jelmer