[PATCHSET]: let configure(waf) fail if --with-ads was specified but ad support was not found

Andrew Bartlett abartlet at samba.org
Fri Nov 2 16:06:34 MDT 2012

On Fri, 2012-11-02 at 17:12 +0100, Bjoern Baumbach wrote:
> Hi,
> On 11/02/2012 02:26 PM, Andrew Bartlett wrote:
> > I still
> > think we should encourage a situation where users have to explicitly
> > choose to build without these important features.
> The attached a patch let waf configure fail if there is no ads support,
> unless --without-ads is specified.

That looks almost right, except that we need to also fail if we don't
have LDAP headers, instead of just not setting HAVE_ADS:

            if conf.CONFIG_SET('HAVE_LDAP'):
                conf.env['HAVE_ADS'] = '1'

Andrew Bartlett

Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org

More information about the samba-technical mailing list