[PATCHSET]: let configure(waf) fail if --with-ads was specified but ad support was not found
obnox at samba.org
Fri Nov 2 06:59:08 MDT 2012
On 2012-11-02 at 23:26 +1100, Andrew Bartlett wrote:
> You are not missing anything. Back in May or so we talked about having
> Samba require krb5, ldap and ACL headers by default, so users would not
> be surprised by the lack of these features in compiled binaries. It
> would make --with-ads the default, and require an explicit --without-ads
> if you didn't want it.
Ah, now I understand your point. :-)
The above would be achieved by failing configure if "with_ads" was
set to True and support was not found. And of course letting the default
at "true" where it currently is.
The proposed patchset does a bit more: It lets configure fail
if --with-ads is specified, but it adds the None default, which
is effectively the auto mode, thereby _not_ changing the default
Not reading back the discussions, I think the default to "auto"
is quite reasonable. If you don't specify anyhting, you'll get
what is there. If you want to enforce it (like packagers will),
you specify --with-ads, and then you don't get surprises.
This is exactly the mode that distributors are used to from
the s3 autoconf build.
What do you think?
Thanks - Michael
> (and the same for ACL support).
> It even got as far as a promise in BUILD_SYSTEMS.txt, but I never
> managed to do the code. I was trying to see if you might take it on.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 206 bytes
Desc: not available
More information about the samba-technical