[PATCH] Fix the talloc tree for returned SD (was Re: [PATCH][WIP] Make vfs_acl_xattr use hash of the posix ACL)

Christian Ambach ambi at samba.org
Fri Nov 2 01:50:10 MDT 2012

Hi Andrew,

On 11/01/2012 01:05 AM, Andrew Bartlett wrote:

> It doesn't get covered by my tests, because so far they don't cover
> directories (something I need to fix anyway), so if you can verify it in
> your known failing case, it would be most appreciated.

The testcase was pretty simple: open the share in Windows Explorer (this
triggers the se_access_check valgrind reports) and then try to display
the ACL via Properties->Security Tab. This one failed to display anything.

> Indeed.  I think this (improved) patch handles that case properly,
> getting new_ace_list under psd->dacl, where it needs to be in the tree,
> or allocating it with talloc_tos() when it will be duplicated anyway.

Yes, looks much better with this patch now.
The stackframe is empty (besides two small strings), no valgrind errors
and Windows Explorer is happy.

I will now continue to work on the GPFS part of it (already found some
memory management issues in the existing POSIX ACL code).

You can have a look at the fix-acls2 branch in my git repo:


More information about the samba-technical mailing list