[PATCH] set 'create mask' and 'directory mask' in fileserver.conf, and then eliminate fileserver.conf

Michael Adam obnox at samba.org
Thu Nov 1 03:11:17 MDT 2012


Looks good!
It is very good to remove the extra config file.
I think we can deal with the defaults issue later.

Pushed to autobuild.

Michael

On 2012-10-31 at 21:59 -0500, Ricky Nance wrote:
> Looks good from the end user standpoint.
> 
> Ricky
> 
> On Wed, Oct 31, 2012 at 7:41 PM, Andrew Bartlett <abartlet at samba.org> wrote:
> 
> > Attached are two patches around our default options for the AD DC.
> >
> > Metze,
> >
> > you asked me a while back about moving the rest of the default options
> > from fileserver.conf into loadparm, so we wouldn't need a distinct
> > fileserver.conf.
> >
> > The attached patch does this.
> >
> > Ricky and Jeremy,
> >
> > The other patch here follows up on your discussion, and makes 'create
> > mask = 0777' and 'directory mask = 0777' the default for the AD DC.
> >
> > The challenge with the combination of these is that if we set things in
> > loadparm, they are hard to undo - we can only determine our server role
> > once we have parsed the smb.conf, and then with the current code we can
> > only override the settings.  The lib/param code has a concept of a
> > default flag we could consult, but it's not in the source3/param code
> > right now.
> >
> > On the plus side, it means that the code running in 'samba-tool ntacl
> > sysvolreset' will use the new defaults, which is really important.
> >
> > The administrator can of course set a per-share value that is different,
> > and that will be honoured, as far as I understand the code.
> >
> > To apply the second patch, we would have to decide that this is a
> > limitation we can live with, at least for now.
> >
> > Ricky, if you could test this, check it does what you expect for your
> > specific issue and if either Metze or Jermey can review it, it would be
> > good to get this into the tree.
> >
> > Thanks,
> >
> > Andrew Bartlett
> > --
> > Andrew Bartlett                                http://samba.org/~abartlet/
> > Authentication Developer, Samba Team           http://samba.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 206 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20121101/1eb1991f/attachment.pgp>


More information about the samba-technical mailing list