serverid patchset ?

[Stefan (metze) Metzmacher]

Am 22.05.2012 20:43, schrieb Jeremy Allison:
> On Tue, May 22, 2012 at 11:41:23AM -0700, Jeremy Allison wrote:
>>
>> The only place where we could get zero valid share modes and
>> a delete on close token is where the client sets delete on
>> close and then the *server* crashes (or is terminated without
>> clean shutdown). This is not a case we can test via experiment
>> against Windows as it's essentially server dependent whether
>> we delete the file or not after server crash.
> 
> Just to make it clear, even sending a TCP reset instead of
> TCP fin from the client won't reproduce this state. We would
> still treat it as SHUTDOWN_CLOSE in the server code.
> 
> We have to crash (or explicitly be aborted) in order to
> reproduce this situation.

I know, but the code from last week didn't have
https://gitweb.samba.org/?p=samba.git;a=commitdiff;h=d79b46f358d7e6fd942bb0f3da2174455e9b1740
See
https://git.samba.org/autobuild.flakey/2012-05-18-0420/samba4.stdout

So the unclean shutdown seems to happens somewhere...

A server crash means the file should be deleted!
It's 100% the same as a TCP disconnect, so we should try to remove the
file on cleanup...

As this is a very old bug, I think we can fix this later...

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20120522/ca30610d/attachment.pgp>