[SCM] Samba Shared Repository - branch master updated

[Jelmer Vernooij]

On Mon, May 21, 2012 at 10:23:16AM +0200, Volker Lendecke wrote:
> On Mon, May 21, 2012 at 01:17:24AM -0700, Matthieu Patou wrote:
> > On 05/21/2012 01:03 AM, Volker Lendecke wrote:
> > >On Fri, May 18, 2012 at 10:09:56AM -0700, Jeremy Allison wrote:
> > >>On Fri, May 18, 2012 at 01:13:03PM +0200, Volker Lendecke wrote:
> > >>>The branch, master has been updated
> > >>>        via  f5ca3f1 s3: Revert the serverid changes, they need more work
> > >>>       from  45082a8 s4-torture: Improve torture test boilerplate, use torture_assert()
> > >>>
> > >>>http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> > >>>
> > >>>
> > >>>- Log -----------------------------------------------------------------
> > >>>commit f5ca3f11e47e48d195616f813b5b2c9e8255c6cd
> > >>>Author: Volker Lendecke<vl at samba.org>
> > >>>Date:   Fri May 18 09:10:02 2012 +0200
> > >>>
> > >>>     s3: Revert the serverid changes, they need more work
> > >>PLEASE DO NOT DO THIS WITHOUT CONSULTATION WITH OTHERS.
> > >>THIS IS NOT YOUR SANDPIT.
> > >To avoid this kind of thread in the future, maybe we should
> > >change autobuild so that it has to run 5 times in a row
> > >successfully before the push is made. Right now we are
> > >somewhere between 1:30h and 2:00h for a push to get through.
> > >This is completely detached from a normal workflow.
> > >Extending that to, say, 8 to 10 hours should not make a
> > >significant difference anymore.
> > -1
> Why? This would avoid a lot of the flaky tests we have seen.
We really should be trying to get the length of the test suite run
down to a reasonable amount of time, rather than making it impossible
to ever do so.

We already have the flaky test bot, which mails about tests in master
that fail. Has that not been catching problems?

Also, how flaky are these tests exactly? Did you not see these
occasional (inexplicable) failures on your local machine before it was
pushed to autobuild?

Cheers,

Jelmer