Latest iniparser commit to v3-6-test has broken the build.

Karolin Seeger kseeger at samba.org
Thu May 10 02:02:03 MDT 2012


Hi Jeremy,

On Wed, May 09, 2012 at 02:46:40PM -0700, Jeremy Allison wrote:
> Hi Karolin and Simo,
> 
> This commit :
> 
> uthor: Simo Sorce <idra at samba.org>
> Date:   Wed May 9 13:55:41 2012 +0200
> 
>     Fix pam_winbind build against newer iniparser library.
>     
>     iniparser_getstr is deprecated and has been removed in newer libraries
>     available in Fedora. Use iniparse_getstring instead.
>     
>     Autobuild-User: Simo Sorce <idra at samba.org>
>     Autobuild-Date: Tue Apr 24 02:56:10 CEST 2012 on sn-devel-104
>     
>     Based on commit adbace20a24b6ae4fbd6d17b7153833f4ac8c88d in master.
> 
> 
> has broken the v3-6-test build.
> 
> The reason is obvious : it replaces in 2 places :
> 
> iniparser_getstr(d, key)
> 
> with :
> 
> iniparser_getstring(d, key).
> 
> Unfortunately the function signature for iniparser_getstring()
> is :
> 
> iniparser_getstring(d, key, def)
> 
> I've attached the correct fix - but there's no reference
> to the bugid that this change fixed. Can you find the bug
> report and add this as an (obvious) fix please ?

pushed.

Thanks a lot for investigating and sorry for breaking the build.
Please note it was my fault, not Simo's!

The bug number is 8915.

Thanks!

Cheers,
Karolin

-- 
Samba			http://www.samba.org
SerNet			http://www.sernet.de
sambaXP			http://www.sambaxp.org



More information about the samba-technical mailing list