[PATCH] Re: Help needed: failure to set posix ACL in s3fs

[Andrew Bartlett]

On Wed, 2012-05-09 at 12:30 +1000, Andrew Bartlett wrote:
> On Wed, 2012-05-09 at 08:00 +1000, Andrew Bartlett wrote:
> > Using my master-devel branch, I've been testing creating a new group
> > policy object (from Windows 7 RSAT)
> > 
> > Attached is the log I get at level 10, with the failure to set the
> > default directory ACL (after successfully setting the file ACL, with
> > what appears to be the same values).
> > 
> > If someone who understands this code better than I could have a look, I
> > would most appreciate it, as this is the primary blocker before we can
> > think about enabling s3fs.
> > 
> 
> I've been looking at this carefully, the the key is that the
> SMB_ACL_GROUP entry for S-1-5-21-4177067393-1453636373-93818737-512 gid
> 3000007 (3000007) is duplicated in the directory case.
> 
> This is because of an interaction with:
> 
> commit a5038ace24559bb02eec8262d3af5b5e78634d16
> Author: Jeremy Allison <jra at samba.org>
> Date:   Fri Sep 2 11:58:56 2011 -0700
> 
>     Part 2 of bugfix for bug #7509 - smb_acl_to_posix: ACL is invalid
> for set (Invalid argument)
>     
>     Only map CREATOR_OWNER/CREATOR_GROUP to ACL_USER_OBJ/ACL_GROUP_OBJ
> in
>     a default(directory) ACL set.

Actually, it was just a typo.  See attached :-)

Andrew Bartlett
-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s3-smbd-Fix-the-creation-of-duplicate-SMB_ACL_GROUP-.patch
Type: text/x-patch
Size: 1115 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20120509/94ba9ca5/attachment.bin>