Some mods to samba.smb.SMB to support test cases for File System ACLs and privs

[Jelmer Vernooij]

Am 31/03/12 16:16, schrieb Richard Sharpe:
> On Sat, Mar 31, 2012 at 6:24 AM, Jelmer Vernooij <jelmer at samba.org> wrote:
>>
>> OK, is this what you had in mind (plus a py_close_file)?
>> I suspect Amitay meant returning an object that represents a file rather
>> than the file descriptor, but this seems to work well too.
> Well, I looked at returning an object but realized that:
>
> 1. It would take more knowledge than I currently have, and
Fair enough.
> 2. Any such object is only relevant in the context of the SMB object anyway ...
It would still be useful to have an object, for convenience.
>> If you're returning a single value, you probably want to return just
>> that rather than a tuple.
> I don't understand.
>
> The quick look I had at the relevant documentation suggested that:
>
>         return Py_BuildValue("i", fnum);
>
> simply built an integer object and that to build a tuple you would
> have to call Py_BuildValue("[i]", fnum) or something like that.
>
> See here: http://docs.python.org/extending/extending.html#building-arbitrary-values
>
> Of course, I could have misread it.
No, I misread your code. :-) It's a bit odd in that it doesn't create a
tuple if you specify a single type, I wasn't aware of that.

Cheers,

Jelmer

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 900 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20120331/9d929dc7/attachment.pgp>