samba.smb.SMB:set_acl seems to generate a bad nttrans:SET_SD request

[Jelmer Vernooij]

Alexander Bokovoy wrote:
>On Sun, Mar 25, 2012 at 18:38, Richard Sharpe
><realrichardsharpe at gmail.com> wrote:
>> 2012/3/25 Richard Sharpe <realrichardsharpe at gmail.com>:
>>> On Sun, Mar 25, 2012 at 7:56 AM, Alexander Bokovoy <ab at samba.org> wrote:
>>>> 2012/3/25 Richard Sharpe <realrichardsharpe at gmail.com>:
>>>> There are quite few places where Python bindings are not yet finished.
>>>> Basically, they followed needs of Samba4 thus perhaps certain features
>>>> are hardcoded.
>>>
>>> Well, if I could only figure out how to quickly rebuild the Python
>>> support (even the stuff in source4/... I would be able to make more
>>> progress :-(
>>
>> Still no progress on that, but here is a more correct patch that also
>> fixes, I think, the PyDoc stuff:
>This one looks fine to me. Perhaps we need to be more expressive on
>what security_info is -- in definitions of the flags, not here.
>
> Let's run it past Jelmer as well.
FWIW, this change seems fine to me too.

(Note that Amitay is the author of the pysmb module specifically, though you're
of course always welcome to ask for reviews from me too)

Cheers,

Jelmer