Replacing smbclient and nmblookup binaries with the source3 equivalents for the Samba4 release.
abartlet at samba.org
Thu Mar 1 14:37:52 MST 2012
On Thu, 2012-03-01 at 10:23 -0800, Jeremy Allison wrote:
> On Thu, Mar 01, 2012 at 10:21:32AM -0800, Jeremy Allison wrote:
> > Currently the smbclient and nmblookup installed in the Samba4
> > install are the ones from source4. The ones from source3 are
> > currently installed as smbclient3 and nmblookup3.
> > As the ones from source3 are the binaries most existing
> > installations and scripts use and have more functionality
> > than the ones from source4 I'm preparing a patch to
> > swap this so that a Samba4 install gets smbclient and
> > nmblookup from source3, and the source4 binaries are
> > installed as smbclient4 and nmblookup4.
> > I'm willing to entertain not installing them at all as
> > an alternative (I don't like having duplicate binaries
> > around to confuse people), but I think at a minimum
> > this change needs doing so we can move closer to a
> > S4 release.
> > I'll post the patch for review once I'm done.
I'll just warn that this is a bit harder than it looks at first. My
suggestion is to start with Kai's patch, but the issue is that the
Samba4 tests use and expect these binaries in a few places.
What we need to do first (as a separate patch) is extend the binary
mapping in selftest/wscript to include smbclient4 and nmblookup4. Then
these need to be passed down into the test scripts as a parameter.
Then, once the mapping system is in place, the rename is easier, as you
only adjust wscript files (including the mapping line in
selftest/wscript) and do not change test semantics.
Finally, we should deal with the many other duplicate testing binaries.
I would like us to have just one smbtorture, outputting subunit, and
avoid having multiple sources of masktest, locktest et al.
> Hmmm. I've just noticed that the ntlm_auth binary
> that is also widely used is also installed as
> ntlm_auth3. Andrew, you're currently working on
> this one - what is your opinion ? Should we make
> the default ntlm_auth3 -> ntlm_auth or the ntlm_auth
> from source4 ?
I'm currently working on this. Once ntlm_auth3 uses gensec on the
client and server, the key functionality will be pretty much identical
anyway. In short I expect to essentially merge these.
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
More information about the samba-technical