[PATCH] Remove .get_challenge from the s3 and s4 auth stack

[simo]

On Sat, 2012-06-30 at 18:43 +1000, Andrew Bartlett wrote: 
> Following on from the removal of the security=server code, this patch
> removes the support that was built for that case, where the auth module
> is able to force the selection of a particular challenge.
> 
> As security=server becoming less useful over time (due to NTLMv2
> requirements) demonstrated, it is getting harder to use this in practice
> and it is now unused in master.  Removing this makes the auth code
> simpler, means that as a server, we will always support NTLM2, which is
> good for security, and also makes it easier to get the auth code async.
> (That is, we don't have to consider if the .get_challenge could block). 
> 
> Any comments?

I really hated this code, I am happy to see it go.

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>