Patchset to add asynchronous open/close to master

Andreas Schneider asn at samba.org
Fri Jun 22 04:45:28 MDT 2012


On Thursday 21 June 2012 15:02:23 Jeremy Allison wrote:
> On Thu, Jun 21, 2012 at 05:55:48PM -0400, simo wrote:
> > Neat,
> > should we add some abort() calls to check the next time glibc decides to
> > use SETXID on anything ... who know some smart fella may decide to set
> > it on getpid() :-P
> 
> I think we only need to care about the setxxx
> calls, not any of the getxxx calls.
> 
> And we never call the setxx calls directly,
> but always through the wrappers in source3/lib/util_sec.c
> so if we make them call the syscalls directly we should be
> ok (IMHO). Plus the wrappers always do a getXXX
> check afterwards to ensure the set succeeded, and
> abort the entire process if any of them failed.

Don't forget about lib/uid_wrapper which overwrites set*uid calls in make 
test.


	-- andreas


-- 
Andreas Schneider                   GPG-ID: F33E3FC6
Samba Team                             asn at samba.org
www.samba.org



More information about the samba-technical mailing list