Patchset to add asynchronous open/close to master
jra at samba.org
Thu Jun 21 16:31:42 MDT 2012
On Thu, Jun 21, 2012 at 06:15:03PM -0400, simo wrote:
> Why the getxxx ?
> Don't we get an error back from the syscal if it fails ?
Sure, but we just want to make sure..
> However the problem I was hinting is at how to find that someone changed
> the id from under us, so I was wondering if we should have a geteuid()
> right before the open and crap out if it doesn't match what we need ...
Sure - but that is a race condition of course :-).
> maybe we could have that enabled only with configure.developer() to
> avoid adding more syscalls in production to the open path.
Once we've wrapped the setXXX calls in smbd with syscall, then I
don't see how it can get swapped out from under us.
More information about the samba-technical