s3: handle non-POSIX compliant Tru64, NetBSD and FreeBSD errno on O_NOFOLLOW symlink open calls

[Andrew Bartlett]

On Fri, 2012-06-15 at 16:29 -0700, Jeremy Allison wrote:
> On Sun, Jun 10, 2012 at 04:11:03PM +0200, Björn Jacke wrote:
> > The branch, master has been updated
> >        via  f75f1d6 s3: handle non-POSIX compliant Tru64, NetBSD and FreeBSD errno on O_NOFOLLOW symlink open calls
> >       from  046dacc s3:smb2_ioctl: make use of file_fsp_smb2()
> > 
> > http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> > 
> > 
> > - Log -----------------------------------------------------------------
> > commit f75f1d62339f0accb4e574645b1d265c75a01b5b
> > Author: Björn Jacke <bj at sernet.de>
> > Date:   Sun Jun 7 13:55:26 2009 +0200
> > 
> >     s3: handle non-POSIX compliant Tru64, NetBSD and FreeBSD errno on O_NOFOLLOW symlink open calls
> >     
> >     or should we leave the NetBSD and FreeBSD platforms just broken? Actually these
> >     two *want* to have broken platforms as they use different errno's than POSIX
> >     demands *interntionally*. The POSIX errno ELOOP for O_NOFOLLOW open calls on
> >     symlinks is clear and unambiguous. See http://gnats.netbsd.org/43154 for the
> >     interesting NetBSD discussion on that.
> 
> Do we need this as a patch in 3.6.x ?
> 
> Just wondering....

My thought on this is this:  Shouldn't this be in libreplace, rather
than #ifdef in the mainline code?

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org