[PATCH] Remove support for sendfile() on LINUX_BROKEN_SENDFILE hosts

Jim McDonough jmcd at samba.org
Fri Jun 15 08:26:10 MDT 2012

On Tue, Jun 5, 2012 at 12:10 PM, Jeremy Allison <jra at samba.org> wrote:
> On Tue, Jun 05, 2012 at 02:55:59PM +1000, Andrew Bartlett wrote:
>> While checking config.h differences I noticed that sles8 (which I have
>> been working to improve the waf build for) does not support sendfile
>> with our _FILE_OFFSET_BITS=64, except via the LINUX_BROKEN_SENDFILE
>> comparability wrapper, which relies on an manual function declaration
>> and 32 bit types.
>> The test for this in waf doesn't pass, and as this feels really dodgy to
>> me, and so I'm just interested to know if folks are OK with this patch
>> to just drop it.  (I should have done this at the time we did the native
>> 64-bit work).
> I'm OK with this if the SLES folks also sign off on it. Any comments
> Jim ?
Go ahead, it's fine with me.

Jim McDonough
Samba Team
SUSE labs
jmcd at samba dot org
jmcd at themcdonoughs dot org

More information about the samba-technical mailing list