idra at samba.org
Thu Jun 14 20:33:05 MDT 2012
On Fri, 2012-06-15 at 10:33 +0930, Rusty Russell wrote:
> On Thu, 14 Jun 2012 09:34:17 +0200, Volker Lendecke <Volker.Lendecke at SerNet.DE> wrote:
> > One comment on the code: I think we don't need the allocator
> > attribute, given that we have ntdb_parse_record.
> I think it's still nice to have, because the allocator attribute also
> allows the struct ntdb_context to be a talloc object. Samba doesn't
> care very much since we wrap everything, but it's neat for other projects.
> ntdb_parse_record() is more efficient than tdb_parse_record(), but it
> can still create a copy. This means you're doing a double-copy to get a
> talloc object. Again, Samba doesn't care, but ntdb_fetch() is good for
> simple code.
Agreed, I would love to have it for the few places where we use libtdb
directly in sssd, which is heavily based on talloc()
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>
More information about the samba-technical