Volker.Lendecke at SerNet.DE
Thu Jun 14 01:34:17 MDT 2012
On Thu, Jun 14, 2012 at 11:50:38AM +0930, Rusty Russell wrote:
> On Wed, 13 Jun 2012 12:58:50 +0200, Michael Adam <obnox at samba.org> wrote:
> > Rusty, I looked at the code to some extent, and I also have a couple of
> > questions and comments:
> > * To re-raise Volker's concern:
> > You have been working on TDB2 for a long time. At least
> > a year or so. Now you seem to have overhauled the database
> > format and the code to some (if I am not mistaken) non-trivial
> > extent in a very short timeframe. That makes me worry too, that
> > this might not be very stable yet. And are the benchmarks now more
> > meaningful than the last ones.
> > We are changing a core infrastructure component here.
> > The change will affect virturall all parts of samba.
> But yes, I've been working on TDB2 on and off for over a year. Which is
> really crazy, since it's about four months of actual work. The rest has
> been timesliced with other things, and the work to integrate it into
> Samba itself.
One comment on the code: I think we don't need the allocator
attribute, given that we have ntdb_parse_record.
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
More information about the samba-technical