Updated patches for exchange setup support

[Matthias Dieter Wallnöfer]

Hi Matthieu,

very impressive work. I hope that the magic number of 120 sec for schema 
refresh has been choosen correctly. If there is no precise Windows 
Server specification rule then it should work out for us.

Some little proposals:

Commit 24d4d45950b9e2 source4/dsdb/samdb/ldb_modules/repl_meta_data.c:
> +       if (!ldb_dn_compare_base(ac->schema->base_dn, 
> req->op.add.message->dn)) {
I would prefer the syntax != / == 0.

Commit  bb8e87c source4/dsdb/repl/replicated_objects.c:
> +               if (ret == LDB_SUCCESS) {
> +                       talloc_free(msg);
> +                       talloc_free(req);
> +                       ret = ldb_transaction_commit(ldb);
> +               } else {
> +                       DEBUG(0, ("Schema update now failed: %s\n", 
> ldb_strerror(ret)));
> +                       ldb_transaction_cancel(ldb);
> +               }
> +
> +               talloc_free(msg);
> +               talloc_free(req);
> +               if (ret != LDB_SUCCESS) {
> +                       DEBUG(0, ("Commit failed: %s\n", 
> ldb_strerror(ret)));
> +                       return WERR_DS_INTERNAL_FAILURE;
> +               }
talloc_free(msg), talloc_free(req) should not be invoked twice.

Thanks,
Matthias

Matthieu Patou schrieb:
> Andrew, Simo, Matthias,
>
> I've updated my patches here:
>
> http://gitweb.samba.org/?p=mat/samba.git;a=shortlog;h=refs/heads/schema
>
> They involves:
>
> * removing the automatic reload of the schema
> * adding periodic of the schema (like in Microsoft implementation)
> * finish handling of schemaUpdateNow so that it really cause the 
> schema to be reloaded right now (or at the end of the transaction)
> * add a signaling between process so that if one process had to reload 
> the schema due to schemaUpdateNow or due to DRS replication then other 
> process dealing with the samdb are aware of it and reload the schema.
> * fix utc/generalized time attributes (we used to treat them as 
> synonyms but there aren't)
> * return the timestamp of the last modified attribute/class as the 
> modifyTimestamp attribute of CN=Aggregate,<SCHEMA_DN>
> * fix crackname
>
> Can you have a look ?
>
> Thanks
> Matthieu.