[PATCH] lib/tevent: Add trace point callback
idra at samba.org
Mon Jun 11 20:03:11 MDT 2012
On Tue, 2012-06-12 at 11:15 +1000, Martin Schwenke wrote:
> On Fri, 08 Jun 2012 08:44:53 -0400, simo <idra at samba.org> wrote:
> > > > > > On Fri, 2012-06-08 at 13:32 +0200, Volker Lendecke wrote:
> > > > > > > On Fri, Jun 08, 2012 at 07:29:34AM -0400, simo wrote:
> > > > > > > > I guess it would also be a good idea to inline
> > > > > > > > tevent_trace_point_callback()
> > > > > > > Are you sure? What about the branch prediction cache?
> > [...]
> > I see what you mean, and it is a good question. I do not have the answer
> > but I am not sure that a miss would cause that much more work in the
> > case when tracing is off.
> Well, I'm not sure whether we have consensus but attached are patches
> to inline tevent_trace_point_callback() and update the version.
I do not think we need to update the version, 0.9.16 has not been
released yet afaik.
> I guess that someone can merge them if desired... :-)
Thanks, a lot.
Volker, which way should we go ?
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>
More information about the samba-technical