code duplication in ccan (was: Re: snprintf on SunOS)

Jelmer Vernooij jelmer at samba.org
Fri Jun 8 10:23:44 MDT 2012


On Thu, Jun 07, 2012 at 02:34:52PM +1000, Andrew Bartlett wrote:
> On Wed, 2012-06-06 at 03:13 -0700, Mihai-Radu, Orza wrote:
> > Thank you for the patch. I managed to go past the asn1 linkage problem, so it helped.
> > 
> > But now I get the following build error:
> > [ 522/3534] Compiling lib/ccan/failtest/failtest.c
> > ../lib/ccan/failtest/failtest.c:8:17: err.h: No such file or directory
> > Waf: Leaving directory `/tmp/samba-4.0.0beta1/bin'
> > Build failed:  -> task failed (err #1):
> >         {task: cc failtest.c -> failtest_1.o}
> > 
> > The err.h C header does not come with SunOS so I guess the compiler should use the replacement functions defined in source4\heimdal_build\replace.c. Is there some config param I'm missing?
> > 
> > Thanks again and regards,
> > Mihai
> 
> In the short term, it seems you should be able to
> 
> rm -rf lib/ccan/failtest
> 
> as this code is unused.  You may have noticed I've mailed the ccan
> maintainer to understand what we are going to use the code for, and how
> to best handle this in the future. 
This is related to something I've been wondering about for a while.
Ccan reinvents the wheel and is separate from lib/util (of which it
duplicates a lot) and has its own test infrastructure. In addition, it
looks like most of ccan isn't actually used anywhere in Samba.

Can we remove it in favor of libsamba-util?

Cheers,

Jelmer


More information about the samba-technical mailing list