[PATCH] lib/tevent: Add trace point callback

simo idra at samba.org
Fri Jun 8 05:29:34 MDT 2012


On Fri, 2012-06-08 at 08:10 +0200, Stefan (metze) Metzmacher wrote: 
> Hi Martin,
> 
> > Set/get a single callback function to be invoked at various trace
> > points.  Define "before wait" and "after wait" trace points - more
> > trace points can be added later if required.
> > 
> > CTDB wants this to log long waits and events.
> > 
> > ================================
> > 
> > * There's a prerequisite patch that adds a tevent_context* to
> >   poll_event_context.  This makes all backends consistent.
> > 
> > * I've been back and forth with Volker a few times to get the patch
> >   into its current state.
> > 
> > Patches also in my git repo at:
> > 
> >   http://git.ozlabs.org/?p=martins-samba.git;a=shortlog;h=refs/heads/tevent-wip
> 
> 
> Can you please remove the globals and put them into struct tevent_context,
> please add a sub struct 'tracing' similar to 'nesting'.

I guess it would also be a good idea to inline
tevent_trace_point_callback()

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>



More information about the samba-technical mailing list