Remove unused finddcs_nbt (Re: [SCM] Samba Shared Repository - branch master updated)

[Andrew Bartlett]

On Fri, 2012-06-08 at 20:42 +1000, Andrew Bartlett wrote:
> On Fri, 2012-06-08 at 13:16 +0300, Alexander Bokovoy wrote:
> > On Fri, Jun 8, 2012 at 12:01 PM, Volker Lendecke
> > <Volker.Lendecke at sernet.de> wrote:
> > > On Fri, Jun 08, 2012 at 06:46:48PM +1000, Andrew Bartlett wrote:
> > >> On Fri, 2012-06-08 at 09:35 +0200, Stefan (metze) Metzmacher wrote:
> > >> > Hi Andrew,
> > >> >
> > >> > > commit 06c90cb6f55701effa4cbafaf189a4de8471949b
> > >> > > Author: Andrew Bartlett <abartlet at samba.org>
> > >> > > Date:   Thu Jun 7 14:21:25 2012 +1000
> > >> > >
> > >> > >     s4-libcli: Remove unused finddcs_nbt
> > >> > >
> > >> > >     This would only do the NBT getdc lookup for a single DC (but would
> > >> > >     find multiple DCs at first stage), but more particular it of course
> > >> > >     uses Netbios rather than DNS names.
> > >> > >
> > >> > >     In any case it was also unused, as we use CLDAP for reliable DC
> > >> > >     location these days.
> > >> > >
> > >> > >     Found by callcatcher
> > >> >
> > >> > I think it's a bug that it's not used.
> > >> >
> > >> > Samba3 DCs doesn't support CLDAP.
> > >>
> > >> Yes, I know that, but the source4/winbindd code has very little hope of
> > >> becoming a working member of an NT4-like domain and we have the
> > >> source3/winbind code for that.
> > >
> > > It is not only the member case. The most important role of
> > > winbind on a DC is to take care of trusts. For migration
> > > scenarios, I would expect many users to create trusts from
> > > S4 to existing S3 domains, so whatever winbind is chosen
> > > needs to be able to connect to those.
> > Agree. Also this is libcli from s4 which means it affects resolving
> > from python bindings. That code (client-side using s4 python bindings)
> > is certainly interested in contacting both AD and s3 DCs by all
> > possible means if needed.
> 
> Sorry folks, I really should have asked here first.  I'll have that
> reverted, and then we can work on how to correctly hook it into the
> libnet code. 
> 
> Thanks for calling me on this one.  

Attached is a patch that should do that (a trivial revert didn't
actually work, due to build system dependency changes since).  

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Revert-s4-libcli-Remove-unused-finddcs_nbt.patch
Type: text/x-patch
Size: 14928 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20120608/c7b2dc93/attachment-0001.bin>