Role of failtest in ccacn?

[Andrew Bartlett]

Rusty,

I'm a bit confused by failtest, and wondered if you could explain it's
role in Samba?

According to callcatcher, failtest is currently totally unused in Samba,
and a git grep shows no calls. 

https://build.samba.org/lcov/data/coverage/samba_4_0_test/unused-fns.txt

failtest_calloc
failtest_close
failtest_exit
failtest_fcntl
failtest_free
failtest_getpid
failtest_has_failed
failtest_init
failtest_lseek
failtest_malloc
failtest_mmap_noloc
failtest_open
failtest_pipe
failtest_pread
failtest_pwrite
failtest_read
failtest_realloc
failtest_write

Additionally, it is causing us some trouble with portability to
platforms without err.h (eg Solaris - SunOS 5.10).  We could work around
that, and have it depend on roken (where we have an err.h), but I don't
want to put in that effort unless we have a role for failtest.
(Additionally roken was just made optional, and is now not built if we
have a system MIT krb5). 

The idea is certainly neat - looking for failures to check for error
returns from malloc etc - I just want to understand how you plan to use
it so I can deal with it correctly.

Thanks,

Andrew Bartlett
-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org