[PATCH] Remove support for sendfile() on LINUX_BROKEN_SENDFILE hosts

Andrew Bartlett abartlet at samba.org
Mon Jun 4 22:55:59 MDT 2012


While checking config.h differences I noticed that sles8 (which I have
been working to improve the waf build for) does not support sendfile
with our _FILE_OFFSET_BITS=64, except via the LINUX_BROKEN_SENDFILE
comparability wrapper, which relies on an manual function declaration
and 32 bit types. 

The test for this in waf doesn't pass, and as this feels really dodgy to
me, and so I'm just interested to know if folks are OK with this patch
to just drop it.  (I should have done this at the time we did the native
64-bit work).

See attached.

Andrew Bartlett
-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-build-Remove-support-for-non-64bit-sendfile.patch
Type: text/x-patch
Size: 6039 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20120605/2216e1f3/attachment.bin>


More information about the samba-technical mailing list