[TEST][PATCH] Replication errors with Samba4

Andrew Bartlett abartlet at samba.org
Tue Jul 31 06:26:10 MDT 2012

On Tue, 2012-07-31 at 10:50 +0200, Stefan (metze) Metzmacher wrote:
> Hi Andrew,
> >>> I've updated the branch.  To reproduce, just run:
> >>>
> >>> make test TESTS=samba4.drs.replica_sync.python 
> >>
> >> I guess it's related to the fact that the conflict resolution also depends
> >> on the invocationId. The timestamps are in 1 sec intervals, in the protocol!
> > 
> > Ouch!  Does that mean I would cause damage with this patch:
> > https://git.samba.org/?p=abartlet/samba.git/.git;a=commitdiff;h=862b26518a0629f6112fb7e6270c0b98ef71a855
> > 
> > (or would the NDR layer just remove the partial seconds anyway?)
> I guess so
> > It seems better to always work with NTTIME - if it's not harmful I'll
> > just change the commit message to clarify. 
> I'd prefer to just skip that patch.

I'll do that.  Thanks for the feedback. 

> >> I think you should find out the invocationId and define the dc with the
> >> lower
> >> invocationId as dc1 and the other as dc2.
> > 
> > I can just put some sleep into the tests to get times different if
> > that's what is going on. 
> maybe for some parts, but you should also test the resolution based on the
> invocationId and assing the dc1 and dc2 variable based on the invocationId.

That certainly sounds like a reasonable extension. 

> > (I've stopped my autobuild, which includes the next beta because it was
> > due today, pending resolving this)
> Didn't it fail on a dbcheck test (something with lastKnownParent)?

It did, and then I fixed that up, then had this discussion.   I'll
upgrade the branch.

Andrew Bartlett

Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org

More information about the samba-technical mailing list