[TEST][PATCH] Replication errors with Samba4

Stefan (metze) Metzmacher metze at samba.org
Tue Jul 31 02:50:16 MDT 2012


Hi Andrew,

>>> I've updated the branch.  To reproduce, just run:
>>>
>>> make test TESTS=samba4.drs.replica_sync.python 
>>
>> I guess it's related to the fact that the conflict resolution also depends
>> on the invocationId. The timestamps are in 1 sec intervals, in the protocol!
> 
> Ouch!  Does that mean I would cause damage with this patch:
> https://git.samba.org/?p=abartlet/samba.git/.git;a=commitdiff;h=862b26518a0629f6112fb7e6270c0b98ef71a855
> 
> (or would the NDR layer just remove the partial seconds anyway?)

I guess so

> It seems better to always work with NTTIME - if it's not harmful I'll
> just change the commit message to clarify. 

I'd prefer to just skip that patch.

>> I think you should find out the invocationId and define the dc with the
>> lower
>> invocationId as dc1 and the other as dc2.
> 
> I can just put some sleep into the tests to get times different if
> that's what is going on. 

maybe for some parts, but you should also test the resolution based on the
invocationId and assing the dc1 and dc2 variable based on the invocationId.

> (I've stopped my autobuild, which includes the next beta because it was
> due today, pending resolving this)

Didn't it fail on a dbcheck test (something with lastKnownParent)?

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20120731/5030227a/attachment.pgp>


More information about the samba-technical mailing list