[PATCH] A merged set of smb.conf parameters!

Andrew Bartlett abartlet at samba.org
Thu Jul 26 20:20:24 MDT 2012

On Tue, 2012-07-24 at 13:23 +0200, Christian Ambach wrote:
> Hi Andrew,
> On 07/24/2012 11:05 AM, Andrew Bartlett wrote:
> > I hope to complete the merge this week.  As I am part-way thought this
> > process, please ping me on any parameter changes until this is finished,
> > so we can co-ordinate.
> I think the following piece also needs to be fixed:
> lib/param/loadpark.c:69 #include "source4/dns_server/dns_update.h"
> IMHO common should not include anything from source4 or source3.
> If this is not on your radar yet, I can provide a patch.

In general, where it does not create crazy header dependencies, it makes
sense to have the defines where the code the parameter is for is

Now, I realise this is in direct contradiction to the patch I just
merged.  Some of those could probably be put back, if we can get them
into 'clean' headers that include without major dependencies. 

The distinction between 'common code', source3 and source4 is being
eroded anyway, so I don't place a very high value on keeping that

In short, I pay more attention to the dependencies using a subsystem or
header comes with than it's location in the tree these days. 

Andrew Bartlett

Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org

More information about the samba-technical mailing list