get_peer_name on disconnected considered harmful to people reading log files ...
realrichardsharpe at gmail.com
Thu Jul 19 15:41:19 MDT 2012
On Thu, Jul 19, 2012 at 2:31 PM, Christian Ambach <ambi at samba.org> wrote:
> On 07/19/2012 10:08 PM, Richard Sharpe wrote:
>>> Jul 16 09:02:24 xxxxyyyzzz smbd: read_fd_with_timeout: client
>>> 0.0.0.0 read error = Connection reset by peer.
>> and the 0.0.0.0 is not very useful.
>> More useful would be to stash away the actual IP address when we
>> accept the socket and use that.
> This log does not exist any more in 3.6 and master.
> They were killed with these two commits:
> 7d16449 s3: Lift smbd_server_fd() from read_data()
> 9671547 s3: Lift smbd_server_fd() from read_fd_with_timeout()
> Maybe you want to make a patch for 3.5 and get them removed as well?
Yeah, I am thinking of that, but I do not want to introduce more
global variable stuff. Unfortunately, the most straightforward way
would be to pass along some state in all the calls :-(
More information about the samba-technical