get_peer_name on disconnected considered harmful to people reading log files ...

[Christian Ambach]

On 07/19/2012 10:08 PM, Richard Sharpe wrote:


>> Jul 16 09:02:24 xxxxyyyzzz smbd[24638]:   read_fd_with_timeout: client 0.0.0.0 read error = Connection reset by peer.
>
> and the 0.0.0.0 is not very useful.
>
> More useful would be to stash away the actual IP address when we
> accept the socket and use that.

This log does not exist any more in 3.6 and master.

They were killed with these two commits:
7d16449 s3: Lift smbd_server_fd() from read_data()
9671547 s3: Lift smbd_server_fd() from read_fd_with_timeout()

Maybe you want to make a patch for 3.5 and get them removed as well?

Cheers,
Christian