Handling secrets.tdb in upgrade.py for classicupgrade

[Gémes Géza]

2012-07-17 01:01 keltezéssel, Andrew Bartlett írta:
> On Mon, 2012-07-16 at 22:15 +0200, Gémes Géza wrote:
>> Hi,
>>
>> I've applied the tdb patch (actually seen that it is in master and
>> pulled from then).
>> Modified the upgrade.py (the new patch is attached).
>> The upgrade doesn't segfaults anymore, however the ldb.search still
>> breaks without any message, and running under valgrind
>> --leak-check=full
>> --track-origins=yes gives:
> First, don't use --leak-check=full --track-origins=yes
>
> Then, avoid programming like
>
> try:
>     <statement>
> except Exception
>     pass
>
> This means, ignore all errors without telling you want happened.  If you
> show the exceptions, it may be clear what is going wrong.  If you need
> to trap on exceptions, do so on only the very few you need to catch,
> such as LDBError (there are other examples in the code for this).
>
> Andrew Bartlett
>
Thank you!

Will check that exception, I was probably sleeping when I wrote that ;-)

Cheers

Geza Gemes