Samba4 patch for manipulating Unix attributes via ADUC

[Andrew Bartlett]

On Fri, 2012-07-13 at 22:05 +0200, Gémes Géza wrote:
> 2012-07-13 07:50 keltezéssel, Andrew Bartlett írta:
> > On Fri, 2012-07-13 at 07:30 +0200, Gémes Géza wrote:
> >
> >> Hi,
> >>
> >> Sorry for being annoying, but what is your opinion about the patch? Is
> >> there anything you would recommend changing?
> >> For simplicity I've reattached the patch.
> >>
> >> Cheers
> >>
> >> Geza
> > The patch is in autobuild.  Indeed, if it had not hit a flaky test (s3dc
> > failed the samr.large-dc test, which is unrelated and quite unusual), it
> > would be in master by now.
> >
> > There is nothing I find more uplifting than enthusiastic developers who
> > are ready and willing to provide tested patches the solve real-world
> > problems.
> >
> > Thanks so very much for your hard work, and I look forward to seeing
> > your patches for the improved s3 migration!
> >
> > Andrew Bartlett
> >
> Thank you for your kindness with me.
> 
> I still have to sort out some problems with the migration patch.
> What is your opinion shall we set the 
> msSFU30MaxUidNumber/msSFU30MaxGidNumber attributes to the current 
> maximum uidnumber/gidnumber + 1?
> Or leave that attrs for now?

I looked to see what precedent we could follow.  The ldapsam:editposix
behaviour is to ask winbind for an id from the idmap pool at runtime,
but that won't help us specify a fixed base for these attributes.  

I don't like just leaving this, particularly if it defaults to 10000 in
the GUI (as then we have no control, and we might know that 10000 is
unsuitable), but I would like time to think about this more before we
put this into the provision.

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org