duplicated code

Jeremy Allison jra at samba.org
Tue Jul 10 22:19:10 MDT 2012

On Tue, Jul 10, 2012 at 04:10:17PM -0700, Herb Lewis wrote:
> In the file lib/pidfile.c (in both source 3 and source4) the
> functions pidfile_create and
> pidfile_pid (which is called by pidfile_create duplicate code that
> begins with the comments
>         /* Add a suffix to the program name if this is a process with a
>          * none default configuration file name. */
> There is also a comment at the beginning of the files that states
> /* this code is broken - there is a race condition with the unlink
> (tridge) */
> Has anyone looked at this race condition?

Not recently. Is this still an issue with the code
in master ?


More information about the samba-technical mailing list