[PATCH] auth: Common function for retrieving PAC_LOGIN_INFO from PAC
abartlet at samba.org
Fri Jul 6 05:57:50 MDT 2012
On Fri, 2012-07-06 at 08:57 +0200, Volker Lendecke wrote:
> On Thu, Jul 05, 2012 at 04:20:30PM -0600, Christof Schmitt wrote:
> > Christof Schmitt/Tucson/IBM wrote on 07/05/2012 01:37:54 PM:
> > > While investigating alternatives to the proposed PAC2SID winbind
> > > interface, i came across this duplicated code. This patch moves
> > > the code for getting to the PAC_LOGIN_INFO to a common function.
> > On a closer look there are a few more instances with the same
> > duplicated code. Here is an updated version of the patch.
> 7 files changed, 54 insertions(+), 123 deletions(-)
> That's enough for me to give a +1. I think Andrew Bartlett
> should ack and potentially push this.
I agree. That duplication certainly has got out of hand.
It's in an autobuild with some other work I've been doing, and should be
in master shortly.
Thank you both very much!
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
More information about the samba-technical