cifs: fetch credentials out of keyring for non-krb5 auth multiuser mounts

Dan Carpenter dan.carpenter at oracle.com
Fri Jan 20 01:21:32 MST 2012


Hi Jeff,

The patch 8a8798a5ff90: "cifs: fetch credentials out of keyring for 
non-krb5 auth multiuser mounts" from Jan 17, 2012, has a problem here:

+       upayload = key->payload.data;
+       if (IS_ERR_OR_NULL(upayload)) {
+               rc = PTR_ERR(key);
                             ^^^
"key" is a valid pointer not an ERR_PTR.  Also "upayload" can be NULL
and PTR_ERR(NULL) is success.

+               goto out_key_put;
+       }

regards,
dan carpenter



More information about the samba-technical mailing list